found a way... it seems to work... would prefer reid looked at it. #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure I understood his concern.
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann and
andreleblanc11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sr3 statusdoesn't show when all instances are missing #795not sure I understood @reidsunderland 's worry when he looked at it. I went into the _resolve routine, which is where it looks at stuff after all the data is collected.
Only the first spot seems to be effective, but saw a second spot where I think it should apply, but doesn't... fixed both just in case. should be used by both sanity and status.